Skip to content

Commit

Permalink
Update policy name
Browse files Browse the repository at this point in the history
Requirement is to update the policy name to "School Targeted Retention
Incentive"
  • Loading branch information
rjlynch committed Sep 18, 2024
1 parent 492c0bb commit ed82b46
Show file tree
Hide file tree
Showing 16 changed files with 38 additions and 33 deletions.
2 changes: 1 addition & 1 deletion app/models/policies/levelling_up_premium_payments.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def notify_reply_to_id
end

def eligibility_page_url
"https://www.gov.uk/guidance/levelling-up-premium-payments-for-teachers"
"https://www.gov.uk/guidance/targeted-retention-incentive-payments-for-school-teachers"
end

def eligibility_criteria_url
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</ul>
<p class="govuk-body">
You will not be eligible for a
<%= link_to(I18n.t("levelling_up_premium_payments.policy_short_name").downcase, Policies::LevellingUpPremiumPayments.eligibility_criteria_url, class: "govuk-link") %>
<%= link_to(I18n.t("levelling_up_premium_payments.policy_short_name"), Policies::LevellingUpPremiumPayments.eligibility_criteria_url, class: "govuk-link") %>
once you start work as a qualified teacher. This is because of the subject you studied.
Eligible subjects for <%= I18n.t("levelling_up_premium_payments.policy_short_name").downcase.pluralize %> are:
</p>
Expand Down
7 changes: 6 additions & 1 deletion app/views/additional_payments/landing_page.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,12 @@
</li>

<li>
<%= govuk_link_to "#{I18n.t("levelling_up_premium_payments.policy_short_name").capitalize} (opens in new tab)", Policies::LevellingUpPremiumPayments.eligibility_page_url, no_visited_state: true, target: "_blank" %> - payment of up to £3,000 for eligible teachers in certain schools, including computing teachers.
<%= govuk_link_to(
"#{I18n.t("levelling_up_premium_payments.policy_short_name")} (opens in new tab)",
Policies::LevellingUpPremiumPayments.eligibility_page_url,
no_visited_state: true,
target: "_blank"
) %> - payment of up to £6,000 for eligible teachers in certain schools, including computing teachers.
</li>
</ul>

Expand Down
10 changes: 5 additions & 5 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -693,13 +693,13 @@ en:
levelling_up_premium_payments:
<<: *additional_payments
purpose: For early career teachers who teach certain subjects and work in disadvantaged schools.
policy_short_name: "Levelling Up Premium Payments"
policy_acronym: "LUP"
payment_name: "Levelling up premium payment"
claim_subject: "Levelling up premium payment"
policy_short_name: "School Targeted Retention Incentive"
policy_acronym: "STRI"
payment_name: "School targeted retention incentive"
claim_subject: "School targeted retention incentive"
claim_amount_description: "Additional payment for teaching"
support_email_address: "levellinguppremiumpayments@digital.education.gov.uk"
information_provided_further_details_link_text: levelling up premium payment (opens in new tab)
information_provided_further_details_link_text: school targeted retention incentive (opens in new tab)
get_a_teacher_relocation_payment: &get_a_teacher_relocation_payment
journey_name: "Get a teacher relocation payment"
feedback_email: "teach.inengland@education.gov.uk"
Expand Down
2 changes: 1 addition & 1 deletion spec/features/admin/admin_claim_allocation_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"All",
"Student Loans",
"Early-Career Payments",
"Levelling Up Premium Payments",
"School Targeted Retention Incentive",
"International Relocation Payments",
"Targeted Retention Incentive Payment For FE Teachers"
]
Expand Down
4 changes: 2 additions & 2 deletions spec/features/admin/admin_claims_filtering_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

expect(page.find("table")).to have_content("ECP").exactly(10).times
expect(page.find("table")).to have_content("TSLR").exactly(7).times
expect(page.find("table")).to have_content("LUP").exactly(2).times
expect(page.find("table")).to have_content("STRI").exactly(2).times

click_on "View claims"
select "Student Loans", from: "policy"
Expand Down Expand Up @@ -99,7 +99,7 @@
select "Unassigned", from: "team_member"
click_on "Apply filters"

expect(page.find("table")).to have_content("LUP").exactly(2).times
expect(page.find("table")).to have_content("STRI").exactly(2).times

lup_claims_unassigned.each do |c|
expect(page).to have_content(c.reference)
Expand Down
6 changes: 3 additions & 3 deletions spec/features/combined_teacher_claim_journey_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,10 @@

expect(page).to have_text("You’re eligible for an additional payment")
expect(page).to have_field("£2,000 early-career payment")
expect(page).to have_field("£2,000 levelling up premium payment")
expect(page).to have_field("£2,000 school targeted retention incentive")
expect(page).to have_selector('input[type="radio"]', count: 2)

choose("£2,000 levelling up premium payment")
choose("£2,000 school targeted retention incentive")

click_on("Apply now")

Expand Down Expand Up @@ -230,7 +230,7 @@

submitted_claim = Claim.by_policy(Policies::LevellingUpPremiumPayments).order(:created_at).last
# - Application complete
expect(page).to have_text("You applied for a levelling up premium payment")
expect(page).to have_text("You applied for a school targeted retention incentive")
expect(page).to have_text("What happens next")
expect(page).to have_text("Set a reminder to apply next year")
expect(page).to have_text("Apply for additional payment each academic year")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def navigate_to_check_mobile_page
click_on("Continue")

# - Eligibility confirmed
choose "£2,000 levelling up premium payment"
choose "£2,000 school targeted retention incentive"
click_on("Apply now")

# - How we will use the information you provide
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@

# - You are eligible for an early career payment
expect(page).to have_text("You’re eligible for an additional payment")
expect(page).to have_field("£2,000 levelling up premium payment")
expect(page).to have_field("£2,000 school targeted retention incentive")
expect(page).to have_selector('input[type="radio"]', count: 2)

choose("£2,000 levelling up premium payment")
choose("£2,000 school targeted retention incentive")

click_on("Apply now")

Expand Down Expand Up @@ -231,7 +231,7 @@
click_on "Continue"
click_on "Continue"

choose "£2,000 levelling up premium payment"
choose "£2,000 school targeted retention incentive"
click_on "Apply now"
click_on "Continue"

Expand Down
2 changes: 1 addition & 1 deletion spec/features/hmrc_bank_validation_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def get_to_bank_details_page
# - Check your answers for eligibility
click_on("Continue")

choose("£2,000 levelling up premium payment")
choose("£2,000 school targeted retention incentive")
click_on("Apply now")

# - How will we use the information you provide
Expand Down
12 changes: 6 additions & 6 deletions spec/helpers/admin/claims_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -644,11 +644,11 @@
end

describe "#admin_policy_options_provided" do
context "Eligible for ECP and LUP" do
context "Eligible for ECP and STRI" do
let(:claim) { create(:claim, :submitted, :policy_options_provided_with_both, policy: Policies::EarlyCareerPayments) }

it "returns both polices" do
answers = [["Early-career payment", "£2,000"], ["Levelling up premium payment", "£2,000"]]
answers = [["Early-career payment", "£2,000"], ["School targeted retention incentive", "£2,000"]]

expect(admin_policy_options_provided(claim)).to match_array answers
end
Expand All @@ -664,17 +664,17 @@
end
end

context "Eligible for LUP only" do
context "Eligible for STRI only" do
let(:claim) { create(:claim, :submitted, :policy_options_provided_lup_only, policy: Policies::LevellingUpPremiumPayments) }

it "returns LUP only" do
answers = [["Levelling up premium payment", "£2,000"]]
it "returns STRI only" do
answers = [["School targeted retention incentive", "£2,000"]]

expect(admin_policy_options_provided(claim)).to match_array answers
end
end

context "No policy_options_provided (not ECP/LUP claim)" do
context "No policy_options_provided (not ECP/STRI claim)" do
let(:claim) { create(:claim, :submitted) }

it "returns no options" do
Expand Down
2 changes: 1 addition & 1 deletion spec/helpers/application_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
context "policy is a LevellingUpPremiumPayments" do
let(:policy) { Policies::LevellingUpPremiumPayments }

it { is_expected.to eq('For more details, you can read about payments and deductions for the <a class="govuk-link govuk-link--no-visited-state" target="_blank" href="https://www.gov.uk/guidance/levelling-up-premium-payments-for-teachers#payments-and-deductions">levelling up premium payment (opens in new tab)</a>') }
it { is_expected.to eq('For more details, you can read about payments and deductions for the <a class="govuk-link govuk-link--no-visited-state" target="_blank" href="https://www.gov.uk/guidance/targeted-retention-incentive-payments-for-school-teachers#payments-and-deductions">school targeted retention incentive (opens in new tab)</a>') }
end

context "policy is a EarlyCareerPayments" do
Expand Down
2 changes: 1 addition & 1 deletion spec/helpers/claims/show_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
context "with a LevellingUpPremiumPayments policy" do
let(:policy) { Policies::LevellingUpPremiumPayments }

it { is_expected.to eq "levelling up premium payment" }
it { is_expected.to eq "school targeted retention incentive" }
end
end

Expand Down
2 changes: 1 addition & 1 deletion spec/mailers/claim_mailer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ class SomePolicy; end
let(:policy) { Policies::LevellingUpPremiumPayments }

it "has personalisation keys for: one time password, validity_duration,first_name and support_email_address" do
expect(mail[:personalisation].decoded).to eq("{:email_subject=>\"Levelling up premium payment email verification\", :first_name=>\"Ellie\", :one_time_password=>123124, :support_email_address=>\"levellinguppremiumpayments@digital.education.gov.uk\", :validity_duration=>\"15 minutes\"}")
expect(mail[:personalisation].decoded).to eq("{:email_subject=>\"School targeted retention incentive email verification\", :first_name=>\"Ellie\", :one_time_password=>123124, :support_email_address=>\"levellinguppremiumpayments@digital.education.gov.uk\", :validity_duration=>\"15 minutes\"}")
expect(mail.body).to be_empty
end
end
Expand Down
8 changes: 4 additions & 4 deletions spec/models/levelling_up_premium_payments_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@

specify {
expect(subject).to have_attributes(
short_name: "Levelling Up Premium Payments",
short_name: "School Targeted Retention Incentive",
locale_key: "levelling_up_premium_payments",
notify_reply_to_id: "03ece7eb-2a5b-461b-9c91-6630d0051aa6",
eligibility_page_url: "https://www.gov.uk/guidance/levelling-up-premium-payments-for-teachers",
eligibility_criteria_url: "https://www.gov.uk/guidance/levelling-up-premium-payments-for-teachers#eligibility-criteria",
payment_and_deductions_info_url: "https://www.gov.uk/guidance/levelling-up-premium-payments-for-teachers#payments-and-deductions"
eligibility_page_url: "https://www.gov.uk/guidance/targeted-retention-incentive-payments-for-school-teachers",
eligibility_criteria_url: "https://www.gov.uk/guidance/targeted-retention-incentive-payments-for-school-teachers#eligibility-criteria",
payment_and_deductions_info_url: "https://www.gov.uk/guidance/targeted-retention-incentive-payments-for-school-teachers#payments-and-deductions"
)
}

Expand Down
2 changes: 1 addition & 1 deletion spec/models/policies_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
expect(described_class.options_for_select).to eq([
["Student Loans", "student-loans"],
["Early-Career Payments", "early-career-payments"],
["Levelling Up Premium Payments", "levelling-up-premium-payments"],
["School Targeted Retention Incentive", "levelling-up-premium-payments"],
["International Relocation Payments", "international-relocation-payments"],
["Targeted Retention Incentive Payment For FE Teachers", "further-education-payments"]
])
Expand Down

0 comments on commit ed82b46

Please sign in to comment.