E2E tests converted to playwright #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onSearchController.cs
* Updated packages to latest version and updated unit test as part of the OwaspHeaders.Core update which changed the default value * Update E2E tests
…nSearchService.cs
* Updated packages and fixed breaking changes * Added null check for header value
ThomasWhittington
changed the title
Minimum allowed line rate is |
sam-c-dfe
reviewed
Jan 17, 2025
Comment on lines
+70
to
+76
| - Add some environment variables | ||
| ``` | ||
| WEBAPP_URL={URL OF THE HOME PAGE} | ||
| AUTH_SECRET={PASSWORD FOR ENVIRONMENT} | ||
| DOMAIN={DOMAIN FOR COOKIE TO BE ADDED TO (when local: localhost)} | ||
| ``` | ||
| - Run the local web app. |
There was a problem hiding this comment.
We can probably remove these steps now as the .env file will work for both local and CI/CD. Also on local, the playwright config will start up the app for us so we don't need to do it explicitly anymore like we did with Cypress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converted all e2e tests from cypress to playwright to improve stability and speed up run times
How Has This Been Tested?
All tests ran locally and in pipelines.
Navigate to e2e project in terminal and run
npx playwright testyou can add --ui to launch testing in the ui
Screenshots
Checklist: