-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rails from 7.1.3.4 to 7.2.0 #9692
Conversation
a9f3226
to
a1305bb
Compare
When upgrading our apps to rails version 7.2: Publish: DFE-Digital/publish-teacher-training#4445 Apply: DFE-Digital/apply-for-teacher-training#9692 Register: DFE-Digital/register-trainee-teachers#4562 We are getting the following error: NoMethodError: undefined method `migration_context' for #<ActiveRecord::ConnectionAdapters::PostgreSQLAdapter:0x0000000000c620 raise ActiveRecord::PendingMigrationError if ActiveRecord::Base.connection.migration_context.needs_migration? This is because of breaking changes and deprecation in rails 7.2: ActiveRecord::Base.connection was changed to with_connection: - https://blog.saeloun.com/2024/07/01/rails-adds-activerecord-base-with-connection/ This deprecation meant that rspec had to be upgraded: - rspec/rspec-rails#2661 Set functional versions of the rspec-rails and rails gems depending on what version of rails you are using.
This may be a handy article https://www.fastruby.io/blog/upgrade-rails-7-1-to-7-2.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking into this.
The current issue lies with the DfE analytics gem. I've opened a PR to help with a fix: DFE-Digital/dfe-analytics#162
A newer version of rails exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
a1305bb
to
a13a067
Compare
183dcdb
to
5528022
Compare
5528022
to
9161a70
Compare
7d4992f
to
af779c2
Compare
af779c2
to
8a44582
Compare
8a44582
to
50eb411
Compare
15426e5
to
1c5daa9
Compare
1c5daa9
to
7ed1828
Compare
7ed1828
to
dff04bd
Compare
180bdad
to
2fef633
Compare
2fef633
to
e728bf6
Compare
e728bf6
to
dff04bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. I'm not sure about the impact of the config.active_record.postgresql_adapter_decode_dates = false
does this change anything in our Application? I assume this is true
by default in Rails 7.2
Bumps rails from 7.1.3.4 to 7.2.0.
Release notes
Sourced from rails's releases.
... (truncated)
Commits
fb6c430
Preparing for 7.2.0 releasec9a5cfd
Merge pull request #52540 from mattbrictson/fix-brakeman-ci-descac2035a
Merge pull request #52555 from rails/rm-fix-system-test7ae1ec1
Remove WEB_CONCURRENCY "auto" from tuning_performance_for_deployment (#52545)0461267
Merge pull request #52554 from erados/patch-1c2e0f6f
Remove redundant Puma configuration settings from fresh config/puma.rb filesecf787c
Puma 5+ now pulls WEB_CONCURRENCY directly from ENV, so we cannot/should not ...573d4bd
Merge pull request #52533 from denys-chaikovskyi/mod/auto-puma-workers0b3404e
Merge pull request #52531 from n-studio/allow-bots6ffa94c
Merge pull request #52524 from rubys/rm-redundant-commentDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)