Revert changelog script change with improvements #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#59 We realised that the previous name for the script was intentional. It was so that it would be automatically kicked off when `npm version` was called from the command line. Using `npm version` not only means the `package-lock.json` gets updated as well, but it also generates the correct tag for us. Finally, we can just decide the change type (major, minor or patch) and let npm work out the bump. This means we're less likely to make a mistake. So now our process when generating a new release will be - decide on the change type - run `npm version [major|minor|patch]` - check the changes - push the commit Much simpler as we don't need to be specific with version numbers.
Cruikshanks
added
the
housekeeping
Jozzey
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#59
We realised that the previous name for the script was intentional. It was so that it would be automatically kicked off when
npm versionwas called from the command line.Using
npm versionnot only means thepackage-lock.jsongets updated as well, but it also generates the correct tag for us. Finally, we can just decide the change type (major, minor or patch) and let npm work out the bump. This means we're less likely to make a mistake.So now our process when generating a new release will be
npm version [major|minor|patch]Much simpler as we don't need to be specific with version numbers.