Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View licence bills Fixes #998

Merged
merged 5 commits into from
May 10, 2024

Conversation

jonathangoulding
Copy link
Collaborator

@jonathangoulding jonathangoulding commented May 10, 2024

Previous work - https://github.com/DEFRA/water-abstraction-system/pull/986/files

Work item - https://eaflood.atlassian.net/browse/WATER-4316

This change will introduce a bills controller, service and presenter to handle the view licence bills page.

This change updates failures from test and additional missing work from the initial diff with the old system.

  • Additional conditions added for the Bill Number Column label
  • Add rebilling notes to the bill number column
  • Add the credit not to in credit accounts

Handle two part tariff string
@jonathangoulding jonathangoulding self-assigned this May 10, 2024
@jonathangoulding jonathangoulding changed the title View licence bills View licence bills Fixes May 10, 2024
@jonathangoulding jonathangoulding marked this pull request as ready for review May 10, 2024 10:49
@Cruikshanks
Copy link
Member

Hold on this one! Have a meeting but need to double-check the rebelling stuff before this gets merged!

Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathangoulding jonathangoulding merged commit fc1a826 into main May 10, 2024
6 checks passed
@jonathangoulding jonathangoulding deleted the view-licence-bill-run-two-part-tariff branch May 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants