Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you want to set up H1 Title text change #965

Merged
merged 4 commits into from
May 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/routes/return-requirement.routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ const routes = [
scope: ['billing']
}
},
description: 'How do you want to set up the return requirement?'
description: 'How do you want to set up the requirements for returns?'
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion app/services/return-requirements/setup.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async function go (sessionId) {

return {
activeNavBar: 'search',
pageTitle: 'How do you want to set up the return requirement?',
pageTitle: 'How do you want to set up the requirements for returns?',
...formattedData
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/services/return-requirements/submit-setup.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ async function go (sessionId, payload) {
return {
activeNavBar: 'search',
error: validationResult,
pageTitle: 'How do you want to set up the return requirement?',
pageTitle: 'How do you want to set up the requirements for returns?',
...formattedData
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/controllers/return-requirements.controller.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,15 +256,15 @@ describe('Return requirements controller', () => {
describe('GET /return-requirements/{sessionId}/setup', () => {
beforeEach(async () => {
Sinon.stub(SetupService, 'go').resolves({
id: '8702b98f-ae51-475d-8fcc-e049af8b8d38', pageTitle: 'How do you want to set up the return requirement?'
id: '8702b98f-ae51-475d-8fcc-e049af8b8d38', pageTitle: 'How do you want to set up the requirements for returns?'
})
})
describe('when the request succeeds', () => {
it('returns the page successfully', async () => {
const response = await server.inject(_options('setup'))

expect(response.statusCode).to.equal(200)
expect(response.payload).to.contain('How do you want to set up the return requirement?')
expect(response.payload).to.contain('How do you want to set up the requirements for returns?')
})
})
})
Expand Down
2 changes: 1 addition & 1 deletion test/services/return-requirements/setup.service.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe('Select Reason service', () => {

expect(result).to.equal({
activeNavBar: 'search',
pageTitle: 'How do you want to set up the return requirement?',
pageTitle: 'How do you want to set up the requirements for returns?',
licenceRef: '01/ABC',
setup: null
}, { skip: ['id'] })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe('Submit Setup service', () => {
expect(result).to.equal({
activeNavBar: 'search',
licenceRef: '01/ABC',
pageTitle: 'How do you want to set up the return requirement?',
pageTitle: 'How do you want to set up the requirements for returns?',
setup: null
}, { skip: ['id', 'error'] })
})
Expand Down
Loading