Refactor View License Summary services and presenters #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangoulding
added
the
housekeeping
Extract the common view license data (data not in the View License tabs) into it's owm service and presenter. Use the new view license and view license summary functionality called from the View License Summary Controller. Optimise the fetch calls to get licence data per service requirement.
jonathangoulding
force-pushed
the
view-license-summary-tab-refactor
branch
from
476ed4d to
2e8c5e3
Compare
move active tab into presenter
create an abastraction wrapper
jonathangoulding
force-pushed
the
view-license-summary-tab-refactor
branch
from
38f5475 to
ea026be
Compare
robertparkinson
approved these changes
May 1, 2024
jonathangoulding
added a commit
that referenced
this pull request
May 1, 2024
The existing service handling view license is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information. This change will introduce a returns controller, service and presenter to handle the view license returns page. This will share he same view as the summary page and load the same 'common data' established in previous work. Both pieces of work are part of - https://eaflood.atlassian.net/browse/WATER-4444 Previous work as mentioned above - #957
Cruikshanks
added a commit
that referenced
this pull request
May 3, 2024
https://eaflood.atlassian.net/browse/WATER-4444 The existing service handling view license is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information. This change will introduce a returns controller, service and presenter to handle the view license returns page. This will share the same view as the summary page and load the same 'common data' established in [previous work](#957). --------- Co-authored-by: Alan Cruikshanks <alan.cruikshanks@gmail.com>
jonathangoulding
added a commit
that referenced
this pull request
May 7, 2024
https://eaflood.atlassian.net/browse/WATER-4316 The existing service handling view licence is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information. This change will introduce a bills controller, service and presenter to handle the view licence bills page. This will share the same view as the summary page and load the same 'common data' established in [previous work](#957).
jonathangoulding
added a commit
that referenced
this pull request
May 7, 2024
* Add View Licence Bills page https://eaflood.atlassian.net/browse/WATER-4316 The existing service handling view licence is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information. This change will introduce a bills controller, service and presenter to handle the view licence bills page. This will share the same view as the summary page and load the same 'common data' established in [previous work](#957).
jonathangoulding
added a commit
that referenced
this pull request
May 8, 2024
https://eaflood.atlassian.net/browse/WATER-4433 https://eaflood.atlassian.net/browse/WATER-4434 The existing service handling view licence is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information. This change will introduce a contact details controller, service and presenter to handle the view licence contact details page. This will share the same view as the summary page and load the same 'common data' established in [previous work](#957).
Cruikshanks
pushed a commit
that referenced
this pull request
May 13, 2024
https://eaflood.atlassian.net/browse/WATER-4433 https://eaflood.atlassian.net/browse/WATER-4434 The existing service handling view licence is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information. This change will introduce a contact details controller, service and presenter to handle the view licence contact details page. This will share the same view as the summary page and load the same 'common data' established in [previous work](#957).
jonathangoulding
added a commit
that referenced
this pull request
May 13, 2024
* Add View Licence contact details page https://eaflood.atlassian.net/browse/WATER-4433 https://eaflood.atlassian.net/browse/WATER-4434 The existing service handling view licence is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information. This change will introduce a contact details controller, service and presenter to handle the view licence contact details page. This will share the same view as the summary page and load the same 'common data' established in [previous work](#957). PR made to optimise the fetch service for the licence contact details Suggested View contact details changes (#1011) In this commit, we have tried to highlight how we think the changes would be implemented if they followed our current norms. - corrections - adding line breaks, extensions to module imports, parens and block body for arrow functions - fetch logic - switching from Objection to Knex directly. Where we are fetching data from various tables to provide a summarised view, and not intending to interact with the instances other than that, dropping to Knex can make things easier and remove the need for additional logic in presenters services - single responsibility - switching the basis for the modules to be single-responsibility. The ViewService will be responsible for fetching and presenting the data for the whole tab. But assume fetching and presenter licence contacts versus customer contacts will be different hence rename/update the fetch and presenter to be licence contact-specific --------- Co-authored-by: Alan Cruikshanks <alan.cruikshanks@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the common view license data (data not in the View License tabs) into it's own service and presenter.
Use the new view license and view license summary functionality called from the View License Summary Controller.
Optimise the fetch calls to get license data per service requirement.
This work is done prior to https://eaflood.atlassian.net/browse/WATER-4444 to allow the common page data to be shared across pages.