Add bill runs setup type page to journey #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4375 > Part of a series of changes related to replacing the create bill run journey to incorporate changes for two-part tariff Having [Add first route to bill run setup journey](#801) we can now add our first page which is where the user selects what bill run type they wish to create. It is planned in the future that there will be 4; annual, supplementary, two-part tariff and two part tariff supplementary. Until we have implemented two-part tariff supplementary though it is just the first 3 options.
This is the route, controller and view plus supporting service and presenter for the GET `/bill-runs/setup/{id}/type` page.
| 'annual', | ||
| 'supplementary', | ||
| 'two_part_tariff', | ||
| 'two_part_tariff_supplementary' |
There was a problem hiding this comment.
This is not in the list of options on the page. is it going to be added later?
There was a problem hiding this comment.
Good point. It is coming. But I couldn't be 100% certain that is what the name of the bill run type will be when we do have to implement it.
So, on reflection, it would be better that we add this as a valid bill run type when we make the changes to support it.
We know 100% we will have to handle this bill run type in the future. But we can't be 100% whether this will be the name for it when we do. So, to be clearer and cleaner removing this valid type for now.
robertparkinson
approved these changes
Mar 11, 2024
Cruikshanks
added a commit
that referenced
this pull request
Mar 11, 2024
https://eaflood.atlassian.net/browse/WATER-4375 > Part of a series of changes related to replacing the create bill run journey to incorporate changes for two-part tariff This adds the second page to the setup bill run journey; select a region. This has a bit more complexity than [Add bill runs setup type page to journey](#802) because depending on the bill run type selected, we are either done or need to go to another page in the journey.
Cruikshanks
added a commit
that referenced
this pull request
Mar 12, 2024
https://eaflood.atlassian.net/browse/WATER-4375 > Part of a series of changes related to replacing the create bill run journey to incorporate changes for two-part tariff This adds the second page to the setup bill run journey; select a region. This has a bit more complexity than [Add bill runs setup type page to journey](#802) because depending on the bill run type selected, we are either done or need to go to another page in the journey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4375
Having Add first route to bill run setup journey we can now add our first page which is where the user selects what bill run type they wish to create.
It is planned in the future that there will be 4; annual, supplementary, two-part tariff and two-part tariff supplementary. Until we have implemented two-part tariff supplementary though it is just the first 3 options.