Create Landing page #728
Merged
Create Landing page #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4359 As part of an internal project for a Junior Developer, Roble (me) has be assigned to create a online form to replace the old paper form for external users to sign up for a water abstraction licence. This PR is to create a landing page for external users.
Beckyrose200
requested changes
Feb 13, 2024
Beckyrose200
requested changes
Feb 14, 2024
Jozzey
reviewed
Feb 14, 2024
There was a problem hiding this comment.
It's looking good 👍🏼 I'll leave it for @Beckyrose200 to approve once she is happy with it.
…er coding conventions
…abstraction-system into create-landing-page
rvsiyad
added a commit
that referenced
this pull request
Feb 20, 2024
As part of a Junior Dev Project, Roble was tasked with creating an online form for the current water abstraction licence paper form. This was previously expected to be used as part of a future implementation for external users to sign up for a licence, but this has now been declared outside the scope. This PR is focused on removing any of the changes from this previous ticket (https://eaflood.atlassian.net/browse/WATER-4359) and PR (Create Landing page #728).
rvsiyad
added a commit
that referenced
this pull request
Feb 20, 2024
* Remove Landing Page From System As part of a Junior Dev Project, Roble was tasked with creating an online form for the current water abstraction licence paper form. This was previously expected to be used as part of a future implementation for external users to sign up for a licence, but this has now been declared outside the scope. This PR is focused on removing any of the changes from this previous ticket (https://eaflood.atlassian.net/browse/WATER-4359) and PR (Create Landing page #728).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4359
As part of an internal project for a Junior Developer, Roble (me) has be assigned to create a online form to replace the old paper form for external users to sign up for a water abstraction licence.
This PR is to create a landing page for external users.