Refactor Prepare Licence For Allocation Service #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4319 As part of the work we have been doing, we've been hacking away at a branch in a mob to build the two-part-tariff service. We have started refactoring this hacky branch and pulling out the various services into their own PR's. DEFRA/water-abstraction-team#105. Since then we have found a much cleaner, more performate way to right the overall service that we have now added into another separate hacky branch. This PR is updating the PrepareLicenceForAllocationService that has already been pulled out and refactoring it to match our new hacky branch.
Beckyrose200
added
the
housekeeping
Cruikshanks
reviewed
Jan 15, 2024
|
Looks all good to me :) |
Cruikshanks
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
The only thing I would ask before merging is that the squashed commit & PR description are updated.
The 'hack' branches once 2PT is complete will be lost. So, we can reference things we're doing on them because there will be nothing to look up.
So, we need to explain in this commit/description that we've realised we can simplify the two-part tariff process and services involved by splitting the old PrepareLicence into 2 separate services.
Beckyrose200
deleted the
refactor-prepare-licence-for-allocation-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4319
This pull request refactors the 'PrepareLicenceForAllocationService' as part of our ongoing effort to enhance the two-part-tariff service. Initially we began by creating a 'hack' branch to build and iterate on the two-part-tariff functionality. In the process of working on these branches, we identified a cleaner and more performant approach to implement the overall service. We realised that the PrepareLicenceForAllocationService could be split into two smaller services, making it easier in the code to follow the two-part-tariff process and making it easier for testing.