Enter abstraction period dates for return set up #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4274 This is a basic page with a form to enter abstraction period dates for a return set up. This is a stub page.
Demwunz
force-pushed
the
WATER-4274-enter-abstraction-period-dates-for-return-set-up-basic-page
branch
from
90af4ac to
d29ab04
Compare
…r-return-set-up-basic-page
…r-return-set-up-basic-page
robertparkinson
requested changes
Dec 28, 2023
| {% from "govuk/components/back-link/macro.njk" import govukBackLink %} | ||
| {% from "govuk/components/button/macro.njk" import govukButton %} | ||
|
|
||
| {% set title = "Enter the abstraction period for the return requirement |
There was a problem hiding this comment.
I don't mind doing it this way but we need to be consistent. some of the pages have the text in the H1 element. so we either need to change the others to this way or make this the same as those.
There was a problem hiding this comment.
@robertparkinson I've created another branch and moved all title strings in other files to use the set.
I'm lifting this from the prototype, so it's less friction when copying across nunjucks code.
…r-return-set-up-basic-page
robertparkinson
approved these changes
Dec 29, 2023
Demwunz
deleted the
WATER-4274-enter-abstraction-period-dates-for-return-set-up-basic-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4274
This is a basic page with a form to enter abstraction period dates for a return set up.
This is a stub page.