Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pm2 config file #6

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add pm2 config file #6

merged 1 commit into from
Oct 10, 2022

Conversation

Cruikshanks
Copy link
Member

DEFRA/water-abstraction-team#55

Currently, both in our local dev Vagrant box and our AWS environments we use pm2 to run the app. This is an architecture we have inherited.

Till such time as we have assimilated the other apps into this project, it will need to run alongside them in the same way.

So, to support this we need to add a pm2 ecosystem file to the project.

Note - We don't include any 'watch' configuration, which is a deviation from the pattern used by the other apps. Because we now all run the projects within our dev Vagrant box pm2 watch doesn't work. This is a consequence of sharing files between the host and the box to allow us to edit on the host but run in the box. Therefore, it makes no sense to include configuration we never use. At some point, we'll bring the other apps in line with this one.

Currently, both in our local dev Vagrant box and our AWS environments we use pm2 to run the app. This is an architecture we have inherited.

Till such time as we have assimilated the other apps into this project it will need to run alongside them in the same way.

So, to support this we need to add a [pm2 ecosystem file](https://pm2.keymetrics.io/docs/usage/application-declaration) to the project.

> Note - We don't include any 'watch' configuration, which is a deviation from the pattern used by the other apps. Becuase we now all run the projects within our dev Vagrant box pm2 watch doesn't work. This is consequence of sharing files between the host and the box to allow us to edit on the host, but run in the box. Therefore, it makes no sense to include configuration we never use. At some point we'll bring the other apps inline with this one.
@Cruikshanks Cruikshanks self-assigned this Oct 10, 2022
@Cruikshanks Cruikshanks added the housekeeping Refactoring, tidying up or other work which supports the project label Oct 10, 2022
@Cruikshanks Cruikshanks marked this pull request as ready for review October 10, 2022 22:37
@Cruikshanks Cruikshanks merged commit 18f4a6a into main Oct 10, 2022
@Cruikshanks Cruikshanks deleted the add-pm2-config branch October 10, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant