Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch bill run service for new view bill run page #537

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

Cruikshanks
Copy link
Member

@Cruikshanks Cruikshanks commented Nov 22, 2023

https://eaflood.atlassian.net/browse/WATER-4223

This service has been added to get the data needed for a new bill run page that will replace the existing one in the legacy service.

The page displays top-level details about the bill run (date created type, region etc) and then a summary for each bill linked to the bill run. The complexity is

  • each bill in the table is expected to include all the licence references linked to the bill
  • if a licence linked to a bill is marked as water_undertaker the bill should be placed in a separate table of 'Water companies' and all other bills will then go in an 'Other abstractors' table

The service needs to fetch the top-level data as well as the bill summary data.

https://eaflood.atlassian.net/browse/WATER-4223

This service has been added to get the needed for a new bill run page that will replace the existing one in the legacy service.

The page displays top level details about the bill run (date created type, region etc) and then a summary for each bill linked to the bill run. The complexity is

- each bill in the table is expected to include all the licence references linked to the bill
- if a licence linked to a bill is marked as `water_undertaker` the bill should be placed in a separate table of 'Water companies' and all other bills will then go in a 'Other abstractors' table

The the service needs to fetch the top level data as well as the bill summary data.
@Cruikshanks Cruikshanks added the enhancement New feature or request label Nov 22, 2023
@Cruikshanks Cruikshanks self-assigned this Nov 22, 2023
@Cruikshanks Cruikshanks marked this pull request as ready for review November 22, 2023 22:46
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cruikshanks Cruikshanks merged commit 7b9ee3a into main Nov 24, 2023
7 checks passed
@Cruikshanks Cruikshanks deleted the add-fetch-bill-run-service branch November 24, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants