Add new CHA create customer change service #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4092 We are working on migrating the change billing account address functionality from the legacy code to this project. A key part of this is being able to tell the [Charging Module API](https://github.com/DEFRA/sroc-charging-module-api) about the change! This change adds a new Charging Module service which handles sending the request. Admittedly it is doing very little. But adding it as a distinct service keeps it consistent with how we are handling requests to the Charging Module.
Jozzey
approved these changes
Aug 31, 2023
Cruikshanks
added a commit
that referenced
this pull request
Aug 31, 2023
https://eaflood.atlassian.net/browse/WATER-4092 We are working on migrating the change billing account address functionality from the legacy code to this project. A key part of this is being able to tell the [Charging Module API](https://github.com/DEFRA/sroc-charging-module-api) about the change! We've [[Added a] new CHA create customer change presenter](#395) and a [[..] new CHA create customer change service](#394). We now add a new `SendCustomerChangeService` to our /billing-accounts to manage both including dealing with an errors with the process.
Cruikshanks
added a commit
that referenced
this pull request
Sep 4, 2023
https://eaflood.atlassian.net/browse/WATER-4092 We are working on migrating the change billing account address functionality from the legacy code to this project. A key part of this is being able to tell the [Charging Module API](https://github.com/DEFRA/sroc-charging-module-api) about the change! We've [[Added a] new CHA create customer change presenter](#395) and a [[..] new CHA create customer change service](#394). We now add a new `SendCustomerChangeService` to our /billing-accounts to manage both including dealing with any errors in the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4092
We are working on migrating the change billing account address functionality from the legacy code to this project. A key part of this is being able to tell the Charging Module API about the change!
This change adds a new Charging Module service which handles sending the request. Admittedly it is doing very little. However, adding it as a distinct service keeps it consistent with how we are handling requests to the Charging Module.