Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notes for contact and company CRM_V2 models #393

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/WATER-4092

We are working on migrating the change billing account address functionality from the legacy code to this project. Whilst working on persisting the company data we learnt some details about how the previous team stored data in the crm_v2.companies table depending on the source.

We wanted to add these notes for future reference, which made us revisit how we did something similar in the ContactModel.

So, this change is just about updating our notes in the models to be consistent.

https://eaflood.atlassian.net/browse/WATER-4092

We are working on migrating the change billing account address functionality from the legacy code to this project. Whilst working on persisting the company data we learnt some details about how the previous team stored data in the `crm_v2.companies` table depending on the source.

We wanted to add these notes for future reference, which made us revisit how we did something similar in the `ContactModel`.

So, this change is just about updating our notes in the models to be consistent.
@Cruikshanks Cruikshanks added the housekeeping Refactoring, tidying up or other work which supports the project label Aug 30, 2023
@Cruikshanks Cruikshanks self-assigned this Aug 30, 2023
@Cruikshanks Cruikshanks marked this pull request as ready for review August 30, 2023 17:18
@Cruikshanks Cruikshanks merged commit d510c50 into main Aug 31, 2023
@Cruikshanks Cruikshanks deleted the update-crm-v2-model-notes branch August 31, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants