Implement TwoPartService 'friendly' response #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4046 We have our `TwoPartService` which is our spike on coming up with a working two-part tariff matching algorithm. But the data its matching has issues - there is _lots_ of it. The records have numerous fields and many are JSONB which means when presented they expand out even more - for 'reasons' few of the tables and hence the entity names match what you see in the UI Reducing the amount of data output to just the key elements will help when assessing a match is right. And as you'll generally have the UI open and the relevant record up it would _really_ help if the response matched what you saw on screen. So, we have created a `FriendlyResponseService`. We fully intend to delete it once we have confirmation the matching algorithm is good. This is our excuse for why it looks horrendous and has no tests! But it means the default response from our `/check` endpoint will make it a lot easier to assess the critical bit; the matching algorithm.
|
SonarCloud is perfectly right to call out the lack of unit tests for this one. But as I stated, I hand on heart promise this will be deleted before two-part tariff billing goes live! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4046
We have our
TwoPartServicewhich is our spike on coming up with a working two-part tariff matching algorithm. But the data it matches has issuesReducing the amount of data output to just the key elements will help when assessing whether a match is right. And as you'll generally have the UI open and the relevant record up it would really help if the response matched what you saw on screen.
So, we have created a
FriendlyResponseService. We fully intend to delete it once we have confirmation the matching algorithm is good. This is our excuse for why it looks horrendous and has no tests!But it means the default response from our
/checkendpoint will make it a lot easier to assess the critical bit; the matching algorithm.