Fix 2PT query #331
Merged
Fix 2PT query #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query was checking the `chargeElements.isSection127AgreementEnabled` column to see if the charge version was a 2 Part Tarrif. This was the incorrect column, we should have been using the `chargeVersions:chargeElements.adjustments` column. This PR fixes that issue.
Cruikshanks
approved these changes
Aug 2, 2023
StuAA78
approved these changes
Aug 2, 2023
Cruikshanks
added a commit
that referenced
this pull request
Aug 3, 2023
When working on [Fix 2PT query](#331) we needed to update a where clause in an Objection query to use a JSONB field. We'd done this a number of times in our tear down service and thought we had to use [Knex's raw()](https://knexjs.org/guide/raw.html). But we happened to see there was also a [whereRaw()](https://knexjs.org/guide/query-builder.html#whereraw) method and whilst on the page [whereJsonPath()](https://knexjs.org/guide/query-builder.html#wherejsonpath). This avoids us having to drop down to `raw()` and is much more in keeping with our preference; first try Objection, then Knex, and only `raw()` if you really have to. To keep things consistent, this updates our existing uses to use `whereJsonPath()`.
Cruikshanks
added a commit
that referenced
this pull request
Aug 3, 2023
When working on [Fix 2PT query](#331) we needed to update a where clause in an Objection query to use a JSONB field. We'd done this a number of times in our tear down service and thought we had to use [Knex's raw()](https://knexjs.org/guide/raw.html). But we happened to see there was also a [whereRaw()](https://knexjs.org/guide/query-builder.html#whereraw) method and whilst on the page [whereJsonPath()](https://knexjs.org/guide/query-builder.html#wherejsonpath). This avoids us having to drop down to `raw()` and is much more in keeping with our preference; first try Objection, then Knex, and only `raw()` if you really have to. To keep things consistent, this updates our existing uses to use `whereJsonPath()`.
Cruikshanks
added a commit
that referenced
this pull request
Aug 3, 2023
When working on [Fix 2PT query](#331) we needed to update a where clause in an Objection query to use a JSONB field. We'd done this a number of times in our tear-down service and thought we had to use [Knex's raw()](https://knexjs.org/guide/raw.html). But we happened to see there was also a [whereRaw()](https://knexjs.org/guide/query-builder.html#whereraw) method and whilst on the page [whereJsonPath()](https://knexjs.org/guide/query-builder.html#wherejsonpath). This avoids us having to drop down to `raw()` and is much more in keeping with our preference; first try Objection, then Knex, and only `raw()` if you really have to. To keep things consistent, this updates our existing uses to use `whereJsonPath()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query was checking the
chargeElements.isSection127AgreementEnabledcolumn to see if the charge version was a 2 Part Tarrif. This was the incorrect column, we should have been using thechargeVersions:chargeElements.adjustmentscolumn. This PR fixes that issue.