Move db-export services to data folder #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4057 We are on the cusp of adding our second bill run type; two-part tariff. Our experience of implementing the first, supplementary billing has shown that we're going to need a lot of services! 😁 So, ahead of starting to implement we are doing some housekeeping in our services folder. The first of these is to move the db-export services into `app/services/data`. We also tweak the name slightly to just `/export` to be more inline with the others (`/seed` and `/tear-down`) i.e. named after what they do rather than what they are doing it to. We already access this functionality from the `/data` endpoint anyway so this also resolves an inconsistency in the repo structure.
Cruikshanks
added
the
housekeeping
Cruikshanks
added a commit
that referenced
this pull request
Jul 10, 2023
https://eaflood.atlassian.net/browse/WATER-4057 We are on the cusp of adding our second bill run type; two-part tariff. Our experience of implementing the first, supplementary billing has shown that we're going to need a lot of services! 😁 So, ahead of starting to implement we are doing some housekeeping in our services folder. The first of these was to [Move db-export services to data folder](#299). The second of these is to move the `services/supplementary-billing/` to `services/billing/supplementary/`.
Cruikshanks
added a commit
that referenced
this pull request
Jul 10, 2023
https://eaflood.atlassian.net/browse/WATER-4057 We are on the cusp of adding our second bill run type; two-part tariff. Our experience of implementing the first, supplementary billing has shown that we're going to need a lot of services! 😁 So, ahead of starting to implement we are doing some housekeeping in our services folder. The first of these was to [Move db-export services to data folder](#299). The second of these is to move the `services/supplementary-billing/` to `services/billing/supplementary/`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4057
We are on the cusp of adding our second bill run type; two-part tariff. Our experience of implementing the first, supplementary billing has shown that we're going to need a lot of services! 😁
So, ahead of starting to implement we are doing some housekeeping in our services folder. The first of these is to move the db-export services into
app/services/data. We also tweak the name slightly to just/exportto be more in line with the others (/seedand/tear-down) i.e. named after what they do rather than what they are doing it to.We already access this functionality from the
/dataendpoint anyway so this also resolves an inconsistency in the repo structure.