Create new Charging Module services for reissuing #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4035 When reissuing/rebilling invoices, we need to send a PATCH rebill invoice request and a GET invoices request to the CM. This PR creates new services to implement them.
The business refers to what we're doing as "reissuing" an invoice. However for historical reasons the Charging Module refers to it as "rebilling". We previously thought it made sense to talk about "rebilling" when dealing with the CM, and "reissuing" everywhere else. However on reflection, we decided that we would prefer to be consistent within our own codebase. We therefore change our terminology to use "reissue" everywhere.
Cruikshanks
approved these changes
Jun 6, 2023
StuAA78
added a commit
that referenced
this pull request
Jul 6, 2023
https://eaflood.atlassian.net/browse/WATER-4036 We have [created the new services we need](#255) to send the appropriate requests to the Charging Module. We now implement invoice reissuing for SROC. This is done with `ReissueInvoicesService`, which calls `FetchInvoicesToBeReissuedService` to get the invoices for reissuing then passes each one to `ReissueInvoiceService` (note singular `Invoice`) which handles the actual reissuing of the invoice. The resulting invoices, invoice licences and transactions are persisted, and a `true` value returned to indicate that db changes have been made. The intent is that this service will be called from `ProcessBillingBatchService`, and its return value used to set the `isBatchPopulated` boolean. This PR initially made some changes to `ProcessBillingBatchService` to accommodate this; however due to a merge conflict (and the fact that the changes don't really belong in this PR) the changes in the [`Refactor to accommodate future service`](b251f8a) commit have been reverted. They will be reinstated in the future PR which adds reissuing to the process billing batch process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4035
When reissuing, we need to send a PATCH rebill invoice request and a GET invoices request to the CM. This PR creates two new services to implement them:
ChargingModuleReissueInvoiceServiceChargingModuleViewInvoiceServiceNote that "reissuing" is what the business calls it (which is reflected in the frontend) and "rebilling" is what the Charging Module and Water Abstraction Service call it. In the Water Abstraction System we choose to call it "reissuing" in order to align ourselves with the terminology used by the business.