-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi Year Supplementary Billing #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3984 Supplementary billing for SRoC currently only handles Financial Year 2022 - 2023, going forward it needs to pick up any changes to charge versions in any year from 2022. Once we have passed Annual Billing 2027 then the engine should only pick up changes to charge versions in the current year and previous 5. All transactions in the available billing period should be picked up in 1 bill run, and be triggered by a single action. This PR is a first pass at creating a billing period that will cover multiple financial years.
Cruikshanks
approved these changes
May 17, 2023
Jozzey
added a commit
that referenced
this pull request
May 17, 2023
https://eaflood.atlassian.net/browse/WATER-3984 Supplementary billing for SRoC currently only handles Financial Year 2022 - 2023, going forward it needs to pick up any changes to charge versions in any year from 2022. Once we have passed Annual Billing 2027 then the engine should only pick up changes to charge versions in the current year and previous 5. All transactions in the available billing period should be picked up in 1 bill run, and be triggered by a single action. This PR adds the remainder of the functionality required for Multi Year Billing not covered in the previous PR #226
Cruikshanks
pushed a commit
that referenced
this pull request
Jun 6, 2023
https://eaflood.atlassian.net/browse/WATER-3984 Supplementary billing for SRoC currently only handles Financial Year 2022 - 2023, going forward it needs to pick up any changes to charge versions in any year from 2022. Once we have passed Annual Billing 2027 then the engine should only pick up changes to charge versions in the current year and the previous 5. All transactions in the available billing period should be picked up in 1 bill run, and be triggered by a single action. This PR adds the remainder of the functionality required for Multi-Year SROC Supplementary Billing not covered in the previous PR #226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3984
Supplementary billing for SRoC currently only handles Financial Year 2022 - 2023, going forward it needs to pick up any changes to charge versions in any year from 2022. Once we have passed Annual Billing 2027 then the engine should only pick up changes to charge versions in the current year and previous 5.
All transactions in the available billing period should be picked up in 1 bill run, and be triggered by a single action.
This PR is a first pass at creating a billing period that will cover multiple financial years.