Amend charge versions fetched for SROC supplementary

[Cruikshanks]

https://eaflood.atlassian.net/browse/WATER-3935

Initial tests of the SROC supplementary bill run process immediately identified charge versions were being included in the bill run that shouldn't be.

The current query is based on WATER-3826, the story that originally defined which charge versions to base the bill run on. It just said

• charge versions linked to a licence flagged for supplementary billing
• that are applicable to the financial year being billed
• where the charge version is linked to a licence that matches the selected region

And by inference, the charge version is for the SROC scheme.

The change we have been asked to make is to further filter the charge versions to only those that show as APPROVED in the water-abstraction-ui.

After some digging we found the water.charge_versions table uses a custom data type for the status column. The only permitted values are

• current
• draft
• superseded

We also checked the UI code and found repos/water-abstraction-ui/src/shared/view/nunjucks/filters/charge-version-badge.js that handles determining which badge to display based on the charge version status.

//  Map the backend statuses to the desired front-end labels from acceptance criteria.
//  Statuses are: 'Draft', 'Review', 'Change Request', 'Approved', 'Replaced' - We will also keep invalid to accomodate errors and edge cases. TT 2020-08-28
const displayedTextTransformer = {
  current: 'approved',
  draft: 'draft',
  approved: 'approved',
  replaced: 'replaced',
  superseded: 'replaced',
  invalid: 'invalid',
  review: 'review',
  changes_requested: 'change request',
  to_setup: 'to set up'
}

It looks like there were a lot more statuses at one point. But the TL;DR; is APPROVED equates to current.

So, this change updates FetchChargeVersionsService to only return charge versions where the status is current.