Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate abstraction conditions view page #1532

Merged
merged 45 commits into from
Jan 10, 2025

Conversation

rvsiyad
Copy link
Contributor

@rvsiyad rvsiyad commented Dec 2, 2024

https://eaflood.atlassian.net/browse/WATER-4825

As the legacy licence view page has now been rebuilt, the next process is to update some of the links pointing to legacy pages. One of these legacy pages is the abstraction conditions view. If we are able to move this over to our system, it will help towards removing the use of old legacy code.

This PR is focused on rebuilding the abstraction conditions view page from the legacy code base.

As the legacy licence view page has now been rebuilt, the next process is to update some of the links pointing to legacy pages.
One of these legacy pages is the abstraction conditions view. If we are able to move this over to our system, it will help towards removing the use of old legacy code.

This PR is focused on rebuilding the abstraction conditions view page from the legacy code base.
@rvsiyad rvsiyad added the housekeeping Refactoring, tidying up or other work which supports the project label Dec 2, 2024
@rvsiyad rvsiyad self-assigned this Dec 2, 2024
@rvsiyad rvsiyad marked this pull request as ready for review January 8, 2025 18:05
@Cruikshanks Cruikshanks added enhancement New feature or request and removed housekeeping Refactoring, tidying up or other work which supports the project labels Jan 9, 2025
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one suggested change! 💪🙇

Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvsiyad rvsiyad merged commit fc899f8 into main Jan 10, 2025
7 checks passed
@rvsiyad rvsiyad deleted the migrate-abstraction-conditions-view branch January 10, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants