Move Return reqs. pages into setup folder #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#126 We are on the cusp of our work to migrate the management of return versions (requirements) from NALD to WRLS going 'live'. This is a significant feature that has seen many iterations since we started. So, before it gets used in earnest, we want to ensure it is 'ship shape and Bristol fashion'! A key part of the tidy-up is moving all modules related to setting up a return version into a `/setup` subfolder, using the same pattern we used for setting up a bill run. Doing this helps us distinguish pages used solely for the purpose of 'setting up' a new return requirement, from those used to view and manage them.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#126
We are on the cusp of our work to migrate the management of return versions (requirements) from NALD to WRLS going 'live'.
This is a significant feature that has seen many iterations since we started. So, before it gets used in earnest, we want to ensure it is 'ship shape and Bristol fashion'!
A crucial part of the tidy-up is moving all modules related to setting up a return version into a
/setupsubfolder, using the same pattern we used for setting up a bill run. We also move the routes to/return-requirements/setup/{sessionId.This helps us distinguish pages used solely to 'set up' a new return requirement from those used to view and manage them.