Add Charging Module create transaction service #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem https://eaflood.atlassian.net/browse/WATER-3911 The transactions we generate in the WRLS service as part of the SROC supplementary bill run need to be added to the Charging Module’s bill run. We need to add a service that knows how to communicate with the charging module to send the request and handle the response. - add the new `CreateTransactionService` - add unit tests for the service
Cruikshanks
force-pushed
the
add-charging-module-create-transaction-service
branch
from
02e2de4 to
e67425a
Compare
Just to bring it more inline with what we send and what actually gets returned.
It is a personal preference that has become a convention in our tests. Executing the thing under test is done within the test rather than a `before()` block. IMHO when this isn't done it is easy to lose sight of what a test is testing as you add more and more unit tests. It does mean you get some duplication. But we think it makes for more readable code.
Cruikshanks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3911
The transactions we generate in the WRLS service as part of the SROC supplementary bill run need to be added to the Charging Module’s bill run. We already created the bill run using
app/services/charging-module/create-bill-run.service.js. So, following that pattern, we addapp/services/charging-module/create-transaction.service.jsin this change.Housekeeping
It is a personal preference that has become a convention in our tests. Executing the thing under test should be done within the test rather than a
before()block.It's our opinion when this isn't done you lose sight of what a test is testing as you add more and more unit tests. It does mean you get some duplication. But we think it makes for more readable code.
Because we based on unit tests on those in
test/services/charging-module/create-bill-run.service.test.jswe spotted this deviation and corrected it as part of this change.