Remove check for licence ended in approve rtn vers #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4600 > Part of the work to migrate return versions from NALD to WRLS We had to make a series of changes in all our projects to move away from using points data held in the `permit.licence` record's JSONB field when we found that if the licence was 'ended' (dead) [water-abstraction-import](https://github.com/DEFRA/water-abstraction-import) does not populate the `current_version` property. This is the only source for points data in the legacy solution. Then we realised even though you could complete the journey, you'd get an error when you tried to approve the new return version! That is because of [WATER-4264](https://eaflood.atlassian.net/browse/WATER-4264) which included the following A/C. ```text AC5: Check answers for the return requirements (error message for revoked/expired/lapsed licence) Given I am viewing the 'Check your answers' page And all the requirements have been entered correctly When I select the 'Approve returns requirements' button but the licence is revoked, lapsed or expired Then I will be shown the standard error page. ``` 🤣 So, the final step to support adding return versions for ended licences is to remove the validation check we added to the approval process.
Cruikshanks
added
the
housekeeping
Mistakenly left in during our last change!
Cruikshanks
requested review from
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
Sep 25, 2024
Cruikshanks
deleted the
remove-licence-ended-check-from-return-version-setup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4600
We had to make a series of changes in all our projects to move away from using points data held in the
permit.licencerecord's JSONB field when we found that if the licence was 'ended' (dead) water-abstraction-import does not populate thecurrent_versionproperty. This is the only source for points data in the legacy solution.Then we realised even though you could complete the journey, you'd get an error when you tried to approve the new return version! That is because of WATER-4264, which included the following A/C.
🤣
So, the final step to support adding return versions for ended licences is to remove the validation check we added to the approval process.