Persist a new return version for 'no returns required' #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4619 Having completed the return requirements setup journey (no-returns-required), we need to persist a return version (start date, reason and notes) to the database. There will be no return requirements in this scenario. When "Approve" is clicked in the `/check` page the data in the session needs to be persisted to the `water.return_versions` table.
I didn't like that this function either returned an empty array or a service, seemed wrong! So I've refactored so an array is always returned, either empty or otherwise.
Jozzey
requested review from
Cruikshanks,
robertparkinson,
jonathangoulding and
Beckyrose200
Cruikshanks
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4619
Having completed the return requirements setup journey (no-returns-required), we need to persist a return version (start date, reason and notes) to the database. There will be no return requirements in this scenario.
When "Approve" is clicked in the
/checkpage the data in the session needs to be persisted to thewater.return_versionstable.