Add licence workflow warning to view licence page #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4572 Currently, when a licence is added or changed, a record with the status of to_setup is added to the workflow. With WRLS taking over the management of return information, this workflow record will no longer be charge-specific. It is also important to know that any licence linked to a workflow record won’t be included in any bill runs. This PR will add a warning text to the new view licence page to highlight to users that a change has been made to the licence and that it won’t be billed until reviewed. This will only be displayed to the user if they have a role that allows them to see the licence set up tab and there is an active workflow record linked to the licence.
…b.com/DEFRA/water-abstraction-system into licence-workflow-warning-licence-page
rvsiyad
requested review from
robertparkinson,
sujithvg,
jonathangoulding and
Beckyrose200
robertparkinson
approved these changes
Jul 25, 2024
Cruikshanks
added a commit
that referenced
this pull request
Aug 30, 2024
https://eaflood.atlassian.net/browse/WATER-4652 In [Add licence workflow warning to view licence page](#1204) we added a new warning message to the view licence page to indicate that a change has been made to a licence and so it has been added to workflow. But our users have spotted it's show for licences that _don't_ have anything in workflow! 😱 We've tracked the problem down to the fact workflow uses a mix of hard and soft deleted records. When we are checking if a licence is in there, we are not discounting soft deleted records. This change fixes the query we use to resolve this.
Cruikshanks
added a commit
that referenced
this pull request
Aug 30, 2024
https://eaflood.atlassian.net/browse/WATER-4652 In [Add licence workflow warning to view licence page](#1204), we added a new warning message to the view licence page to indicate that a licence change has been made and that it has been added to the workflow. But our users have spotted it's showing for licences that _don't_ have anything in workflow! 😱 We've tracked the problem down to the workflow's use of a mix of hard and soft deleted records. When we check if a licence is in there, we do not discount soft deleted records. This change fixes the query we used to resolve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4572
Currently, when a licence is added or changed, a record with the status of to_setup is added to the workflow. With WRLS taking over the management of return information, this workflow record will no longer be charge-specific. It is also important to know that any licence linked to a workflow record won’t be included in any bill runs.
This PR will add a warning text to the new view licence page to highlight to users that a change has been made to the licence and that it won’t be billed until reviewed. This will only be displayed to the user if they have a role that allows them to see the licence set up tab and there is an active workflow record linked to the licence.