Remove multiple issues showing as review status on two-part tariff pages #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4517 During testing for the two-part tariff review screens by the billing and data team, it was noted that if a licence had multiple issues (even if the issues where all of a ready status) that the licence would be marked as a review status. The point of the 'statuses' was to make issues visible to users and direct them if there was action needed. If a licence has two issues and these are both of a 'ready' status then it doesn't need any action from the team. This PR is to change the logic to remove multiple issues being flagged as a review status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4517
During testing for the two-part tariff review screens by the billing and data team, it was noted that if a licence had multiple issues (even if they were all of a 'ready' status) the licence would be marked as a 'review' status. The point of the statuses was to make issues visible to users and direct them if action was needed. If a licence has two issues, both of a 'ready' status, then it doesn't have any action for the team to complete. This PR changes the logic to remove multiple issues flagging as a review status.