Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update two-part tariff review views to add Cypress data test attributes #1063

Merged
merged 13 commits into from
Jun 5, 2024

Conversation

Beckyrose200
Copy link
Contributor

https://eaflood.atlassian.net/browse/WATER-4450

We've finished building all the pages for the two-part tariff review and are now working on the acceptance tests. While writing these tests, we found a few places where the data test attribute on the view needs to be updated to make it clearer and easier to find in the acceptance tests file.

https://eaflood.atlassian.net/browse/WATER-4450

We've finished building all the pages for the two-part tariff review and are now working on the acceptance tests. While writing these tests, we found a few places where the data test attribute on the view needs to be updated to make it clearer and easier to find in the acceptance tests file.
@Beckyrose200 Beckyrose200 added the enhancement New feature or request label May 31, 2024
@Beckyrose200 Beckyrose200 self-assigned this May 31, 2024
@Beckyrose200 Beckyrose200 changed the title Update two-part tariff review views to add Cypress test hooks Update two-part tariff review views to add Cypress data test attributes May 31, 2024
@Beckyrose200 Beckyrose200 marked this pull request as ready for review June 5, 2024 08:32
app/views/bill-runs/review-licence.njk Outdated Show resolved Hide resolved
app/views/bill-runs/review-licence.njk Outdated Show resolved Hide resolved
app/views/bill-runs/review-licence.njk Outdated Show resolved Hide resolved
@Beckyrose200 Beckyrose200 requested a review from Jozzey June 5, 2024 12:47
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Beckyrose200 Beckyrose200 merged commit c0282c0 into main Jun 5, 2024
6 checks passed
@Beckyrose200 Beckyrose200 deleted the update-cypress-test-hooks-two-part-tatiff-review branch June 5, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants