Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adjustment factors link #1035

Merged
merged 4 commits into from
May 20, 2024
Merged

Fix adjustment factors link #1035

merged 4 commits into from
May 20, 2024

Conversation

Beckyrose200
Copy link
Contributor

https://eaflood.atlassian.net/browse/WATER-4439

During the testing for the above ticket it was noted that if an adjustment factor is removed from a licence on the set adjustment factor page, then the link is removed from the charge reference details page after. This is incorrect as the link should always stay if a charge factor was present initially. This PR adds in the functionally for the link to always be present if a charge factor was initially on the licence.

https://eaflood.atlassian.net/browse/WATER-4439

During the testing for the above ticket it was noted that if an adjustment factor is removed from a licence on the set adjustment factor page, then the link is removed from the charge reference details page after. This is incorrect as the link should always stay if a charge factor was present initially. This PR adds in the functionally for the link to always be present if a charge factor was initially on the licence.
@Beckyrose200 Beckyrose200 added the bug Something isn't working label May 20, 2024
@Beckyrose200 Beckyrose200 self-assigned this May 20, 2024
@Beckyrose200 Beckyrose200 marked this pull request as ready for review May 20, 2024 12:39
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Beckyrose200 Beckyrose200 merged commit 927c141 into main May 20, 2024
6 checks passed
@Beckyrose200 Beckyrose200 deleted the fix-adjustment-factors-link branch May 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants