Fix unsent bills displaying in licence bills tab #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4316 In [Add View Licence Bills page](#986) we added support for displaying the bills linked to a licence in the view licence page's 'Bills' tab. Only we didn't spot that it should only be 'sent' bills. This change updates the relevant fetch service to ensure the bills we get back are only those with a status of 'sent'.
Cruikshanks
force-pushed
the
fix-bills-in-bills-tab
branch
from
4099b3b to
9dcf668
Compare
The service has a withGraphFetched that we are assuming is finding the matching bill run as we know the presenter this data gets passed to is expecting it. However, coming in to add a test case for our currently failing scenario we spotted that the existing test is not actually checking for the bill run. Nor was the bill run created actually linked to the bill. So, we remove everything to do with the bill run from this test to highlight the point we'll need to do some refactoring to ensure the existing scenarios are covered before we make our changes.
Now we have something we can add our scenario around 'sent' bill runs to.
We have a test that describes what happens when a licence has bills. If only for documentation purposes, when we make a statement of behaviour like that it can be handy to show what happens when that is not the case.
```
Fetch Licence Bills service
when the licence has bills
and they are linked to a 'sent' bill run
✔ 1871) returns results (14 ms)
but they are not linked to a 'sent' bill run
✔ 1872) returns no results (3 ms)
when the licence has no bills
✔ 1873) returns no results (4 ms)
````
jonathangoulding
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4316
In Add View Licence Bills page we added support for displaying the bills linked to a licence in the view licence page's 'Bills' tab.
Only we didn't spot that it should only be 'sent' bills.
This change updates the relevant fetch service to ensure the bills we get back are only those with a status of 'sent'.