Remove two-part tariff check endpoint from project #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
added
the
housekeeping
https://eaflood.atlassian.net/browse/WATER-4057 To support the initial stages of building the new SROC two-part tariff match & allocate engine we created a `/check` endpoint. This would allow devs and testers alike to trigger the engine and review the results. We are now sufficiently far along in the build of two-part tariff that we can perform the same checks using the review pages we've built. In fact, the focus has been on those pages for so long we'd need to make changes to our `/check` endpoint to get it up to par! It was only intended to be a temporary thing and now seems a good time to say goodbye. So, hank you for your services to the cause `/check`! 🫡 😢
Cruikshanks
force-pushed
the
delete-2pt-check-code
branch
from
c9c299d to
2334efd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4057
To support the initial stages of building the new SROC two-part tariff match & allocate engine we created a
/checkendpoint. This would allow devs and testers alike to trigger the engine and review the results.We are now sufficiently far along in the build of two-part tariff that we can perform the same checks using the review pages we've built. The focus has been on those pages for so long we'd need to change our
/checkendpoint to get it up to par!It was only intended to be a temporary thing and now seems a good time to say goodbye.
So, thank you for your services to the cause
/check! 🫡 😢