Fix all max-len ESLint rule infractions #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
added
the
housekeeping
DEFRA/water-abstraction-team#115 In [Exclude long strings from ESLint max-len rule](#992) we updated our ESLint [max-len](https://eslint.style/rules/js/max-len) to exclude long strings or template literals from being flagged as issues. That reduced the noise (there were lots of infractions!) and helped us see actual long lines of logic which should be refactored. This fixes all the remaining `max-len` infractions.
Cruikshanks
force-pushed
the
fix-max-line-infractions
branch
from
2cb7512 to
c96bf49
Compare
Cruikshanks
force-pushed
the
fix-max-line-infractions
branch
from
c96bf49 to
6862a7a
Compare
Cruikshanks
added a commit
that referenced
this pull request
May 12, 2024
DEFRA/water-abstraction-team#115 Following on from [Fix all max-len ESLint rule infractions](#1001) this change fixes the remaining infractions based on our current rules (all 1 of them!)
Cruikshanks
added a commit
that referenced
this pull request
May 12, 2024
DEFRA/water-abstraction-team#115 Following on from [Fix all max-len ESLint rule infractions](#1001) this change fixes the remaining infractions based on our current rules (all 1 of them!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#115
In Exclude long strings from ESLint max-len rule we updated our ESLint max-len to exclude long strings or template literals from being flagged as issues.
That reduced the noise (there were many infractions!) and helped us see long lines of logic that should be refactored.
This fixes all the remaining
max-leninfractions.