Use destructured billingBatchId

We spotted that we were using `billingBatch.billingBatchId` when we were already destructuring this, so we move to using this directly
DEFRA · May 15, 2023 · 15ba5aa · 15ba5aa
1 parent 829a8c4
commit 15ba5aa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/services/supplementary-billing/process-billing-batch.service.js b/app/services/supplementary-billing/process-billing-batch.service.js
@@ -50,10 +50,10 @@ async function go (billingBatch, billingPeriod) {
     await _updateStatus(billingBatchId, 'processing')
 
     const chargeVersions = await _fetchChargeVersions(billingBatch, billingPeriod)
-    const invoiceAccounts = await _fetchInvoiceAccounts(chargeVersions, billingBatch.billingBatchId)
+    const invoiceAccounts = await _fetchInvoiceAccounts(chargeVersions, billingBatchId)
 
     // We pre-generate our billing invoices ahead of time to ensure we have only one invoice per account id
-    const billingInvoices = _generateBillingInvoices(invoiceAccounts, billingBatch.billingBatchId, billingPeriod)
+    const billingInvoices = _generateBillingInvoices(invoiceAccounts, billingBatchId, billingPeriod)
 
     for (const chargeVersion of chargeVersions) {
       // Retrieve our previously-generated billing invoice for this charge version's invoice account