Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cole Thierrin to website #139

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

CThierrin
Copy link

Resolves issue #138

@dchiller
Copy link
Contributor

I don't think there should be this large of a diff of lab_members/index.html to add your personal page... could you check that?

@CThierrin
Copy link
Author

I don't think there should be this large of a diff of lab_members/index.html to add your personal page... could you check that?

It's bizarre, the only lines added are lines 118 and 119. The rest of the diff seems to be some sort of Ship of Theseus-esque glitch going on with the check

@dchiller
Copy link
Contributor

dchiller commented Apr 18, 2024

I made a draft PR at #141 that I think does what you want without the extraneous diff:

  • pulled CThierrin:master.
  • checked out lab_members/index.html from master.
  • Added lines 118 + 119 (your links)
  • Committed that

Could you try making that change to your branch? Or feel free to check over that PR and mark it "Ready for Review"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants