Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add octave displacement for clefs #956

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Conversation

jinh0
Copy link
Collaborator

@jinh0 jinh0 commented Aug 10, 2022

Fixes #648 .

demo.mov

Before this PR can be merged, there's one issue:

@annamorphism or @JoyfulGen , what is the minimum / maximum octave a neume can be? Currently, clef displacement has free reign and can lead to neumes having a -1 octave. From my testing, the maximum octave a neume can be is 6.

@annamorphism
Copy link

@jinh0 You mean, in what it can do in Neon, or what it might represent musically? Assuming middle C=C3, chant never goes outside the range G1 to E4 (and even that's pretty generous really). So while you can currently give neumes all sorts of octaves, it really only makes sense to have them go from 1-4.

@jinh0
Copy link
Collaborator Author

jinh0 commented Aug 10, 2022

Hey @annamorphism , sorry, to clarify, this new feature in Neon allows you to have pitches displaced down to F-1 all the way up to C6.

If it doesn't make sense musically, should Neon restrict the user from displacing neumes to pitches below octave 1 / above octave 4?

@annamorphism
Copy link

@jinh0 I mean, a range from -1 to 6 is pretty sensible and won't break anything. you could make it even smaller if you wanted to, though.

Copy link
Member

@yinanazhou yinanazhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the dropdown menu for clef shape change is not functioning
  • the HTML part for two dropdown menus for clef contains several repeated id attributes

@yinanazhou yinanazhou merged commit 89806b6 into develop Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants