Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add types to notifications #924

Merged
merged 2 commits into from
Jul 18, 2022
Merged

✨ Add types to notifications #924

merged 2 commits into from
Jul 18, 2022

Conversation

jinh0
Copy link
Collaborator

@jinh0 jinh0 commented Jul 14, 2022

  • Add 'default', 'error', 'warning', 'success' types
  • Set opacity to 1 for notifications
  • Add emojis for notifications :)
  • Changed a couple notifications to have these new types, not all of them though

@jinh0
✨ Add types to notifications
1dafdba 
- Add 'default', 'error', 'warning', 'success' types
- Set opacity to 1 for notifications
- Add emojis for notifications :)
- Changed a couple notifications to have these new types, not all of them though
@jinh0 jinh0 requested a review from yinanazhou July 14, 2022 18:12
yinanazhou
yinanazhou requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@yinanazhou yinanazhou left a comment •
edited by jinh0
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please assign notification type to these notifications:

  • Save changes
  • insert layer element to nearest syllable

image

  • out-of-bound glyph

image

@yinanazhou yinanazhou merged commit 42fbcb7 into develop Jul 18, 2022
@jinh0 jinh0 deleted the notification-type-fix branch August 22, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinanazhou yinanazhou yinanazhou requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinh0 @yinanazhou