🐛 Fix divlines jumping to wrong staff lines. #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Give more accurate typing for dragStartCoords, tuple of 2 numbers. - Get rid of unused variables relativeX/Y, and use arrow functions instead of regular functions to pass down `this` correctly. - Reformat longer function chain calls to be more readable, according to the ESLint / Prettier standard.
When dragging and dropping a divline or an accidental, the staff the cursor is over is calculated, and a call to a new editor action called changeStaffTo is called. This fixes the issue of divlines weirdly jumping to another staff due to our default changeStaff() function.
yinanazhou
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #864 .
Demo:
Screen.Recording.2022-06-15.at.3.26.49.PM.mov