🚑 Fix severe memory leak (high memory consumption) #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding the change of variable name from `mei` to `svg`: all other functions and classes refer to SingleView's `mei` as `svg`, and the type itself of the variable is `SVGSVGElement`. There is only one <svg> element that matters, so there is no vagueness in its name.
jinh0
changed the title
Closed
yinanazhou
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is fixed
Fixes #767 .
Dereferences SVG object when
NeonCore.edit()is called.In my personal usage, what used to take up to 16 GB of RAM on my computer now takes up only 300 MB of RAM.
Memory usage in Neon should now be consistent (except due to the storing of strings in undo/redo stacks).
Tested on
Google Chrome, Safari, and Microsoft Edge.
EDIT: Works on Firefox as well.
What still needs to be done
Storing of strings must be fixed in the future.
The MEI string and SVG object of neonCache should be accessed through a memory-safe function.