Remove autogenerated json from repo #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliefoxtwo
force-pushed
the
feature/remove-autogenerated-json
branch
from
390e9dd to
7273e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON files will still be present in both the nightly and unified releases - this just removes them from the git repo to reduce conflicts and excess changes.
I've left the Addresses.h file for now, as the file in the arduino repo is often outdated. Ideally we'll find a solution for this in the future too.
Workflow action responsible for generating json files prior to release
dcs-bios/.github/workflows/release-nightly.yml
Lines 56 to 59 in cd7dbdf