Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P-47-D-40, Detrola LF Radio #174

Closed
jdahlblom opened this issue Jul 16, 2023 · 8 comments
Closed

P-47-D-40, Detrola LF Radio #174

jdahlblom opened this issue Jul 16, 2023 · 8 comments

Comments

@jdahlblom
Copy link
Contributor

I implemented this radio in DCSFP and noticed that there is something wrong.
DETROLA_FREQU_SEL which should change the frequency seems to change the volume dial for the Detrola. But it seems random. Sets a fixed value.
DETROLA_VOL, regardless if I put 5000 or -5000 in ctrlref the dial's value increases. And it doesn't change with the value given.

@jdahlblom
Copy link
Contributor Author

I noticed problems with P-51D too.
BUT :
Although variable_step is broken then set_state works. So I will use that instead. That is enough for me.

@WarLord211 WarLord211 reopened this Jul 16, 2023
@WarLord211
Copy link
Member

WarLord211 commented Jul 16, 2023

which control for the P-51?

fix for P-47 is inbound

WarLord211 added a commit that referenced this issue Jul 16, 2023
@jdahlblom
Copy link
Contributor Author

jdahlblom commented Jul 16, 2023

P-47D
definePotentiometer("DETROLA_FREQU_SEL", 24, 3001, 137, {0, 1}, "Detrola Receiver", "Detrola Frequency Selector") definePotentiometer("DETROLA_VOL", 24, 3002, 138, {0, 1}, "Detrola Receiver", "Detrola Volume")

P-51D
definePotentiometer("DETROLA_FREQUENCY", 26, 3004, 137, {0, 1}, "Detrola", "Detrola Frequency Selector") definePotentiometer("DETROLA_VOLUME", 26, 3001, 138, {0, 1}, "Detrola", "Detrola Volume")

@WarLord211
Copy link
Member

thats for P-47 its fixed.
i mean the P-51 bug.

@jdahlblom
Copy link
Contributor Author

jdahlblom commented Jul 16, 2023

OK so I closed the issue too early. And I was mixed the airplanes up, I was testing the Detrola on the P-51 and the set_state worked there but set_state does not work on P-47D. So P-47D is 100% "broken".

@jdahlblom
Copy link
Contributor Author

OK will test the fix! Thanks!!

@WarLord211
Copy link
Member

P-51 works as it should? can find a bug

@jdahlblom
Copy link
Contributor Author

jdahlblom commented Jul 16, 2023

Detrola set_state for P-47D works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants