Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movescu's --bit-preserving option is not respecting the --output-directory option (issue #1122) #98

Commits on May 3, 2024

  1. Temptative fix to bit-preserving option ignoring output directory

    Simplest attempt at correcting issue #1122.
    When movescu is called with +B (--bit-preserving) option, the output file ends up in the current working directory as opposed to the desired output directory even if you add the -od (--output-directory) option in the command line.
    
    Note that a better approach could be to have a singular writing function and adjust the function signatures to pass whether other processing logic should be skipped. However, that could cause a lot of headaches ensuring all logic paths are checked against the current bit-preserving behavior of outputting the data as-is.
    
    I leave the option to the maintainer if to request further work to address this issue more comprehensively or if the change proposed here is good enough for the project.
    
    The changes here appears to work as intended in my test environment.
    luissantosHCIT authored May 3, 2024
    Configuration menu
    Copy the full SHA
    89dc5af View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    d8099b8 View commit details
    Browse the repository at this point in the history
  2. Update movescu.cc

    Stylistic correction to comments
    luissantosHCIT authored May 24, 2024
    Configuration menu
    Copy the full SHA
    ac8819b View commit details
    Browse the repository at this point in the history
  3. Correction of deleteFile block

    Unlike movescu, storescp does not recompute the file path in the storeSCP callback. It assumes that imageFileName already includes the directory name. However, I separated the imageFileName generation from the full path generation, so I realized I needed to correct the deleteFile logic as well. Will need to do something like this in movescu to ensure consistency across both codebases.
    luissantosHCIT authored May 24, 2024
    Configuration menu
    Copy the full SHA
    d3bed09 View commit details
    Browse the repository at this point in the history
  4. Refactor storeSCPCallback for consistency with storescp

    Keeping consistency between movescu and storescp so they both look at the file path in a similar manner.
    luissantosHCIT authored May 24, 2024
    Configuration menu
    Copy the full SHA
    1bf82d1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3ab2853 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b4be7bd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    33d1124 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5580354 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Resolving merge conflict with upstream

    Attempting to resolve merge conflict that arose in storescp due to new commits in the upstream mirror. It looks like it is addressing the   path construction with a slightly different approach. A second commit will be added after I check if the directory path is getting added twice.
    luissantosHCIT authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f919b81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2aad6c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    016c2b7 View commit details
    Browse the repository at this point in the history
  4. Clean up of previously suggested solution in storescp

    Now that master is using snprintf(), I decided to remove my previously proposed solution in favor of the snprintf() suggestion. Also, adding bracket to if statement per comments in PR.
    luissantosHCIT authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    7fa7df1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1304f8a View commit details
    Browse the repository at this point in the history