-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
movescu's --bit-preserving option is not respecting the --output-directory option (issue #1122) #98
Commits on May 3, 2024
-
Temptative fix to bit-preserving option ignoring output directory
Simplest attempt at correcting issue #1122. When movescu is called with +B (--bit-preserving) option, the output file ends up in the current working directory as opposed to the desired output directory even if you add the -od (--output-directory) option in the command line. Note that a better approach could be to have a singular writing function and adjust the function signatures to pass whether other processing logic should be skipped. However, that could cause a lot of headaches ensuring all logic paths are checked against the current bit-preserving behavior of outputting the data as-is. I leave the option to the maintainer if to request further work to address this issue more comprehensively or if the change proposed here is good enough for the project. The changes here appears to work as intended in my test environment.
Configuration menu - View commit details
-
Copy full SHA for 89dc5af - Browse repository at this point
Copy the full SHA 89dc5afView commit details
Commits on May 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d8099b8 - Browse repository at this point
Copy the full SHA d8099b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac8819b - Browse repository at this point
Copy the full SHA ac8819bView commit details -
Correction of deleteFile block
Unlike movescu, storescp does not recompute the file path in the storeSCP callback. It assumes that imageFileName already includes the directory name. However, I separated the imageFileName generation from the full path generation, so I realized I needed to correct the deleteFile logic as well. Will need to do something like this in movescu to ensure consistency across both codebases.
Configuration menu - View commit details
-
Copy full SHA for d3bed09 - Browse repository at this point
Copy the full SHA d3bed09View commit details -
Refactor storeSCPCallback for consistency with storescp
Keeping consistency between movescu and storescp so they both look at the file path in a similar manner.
Configuration menu - View commit details
-
Copy full SHA for 1bf82d1 - Browse repository at this point
Copy the full SHA 1bf82d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ab2853 - Browse repository at this point
Copy the full SHA 3ab2853View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4be7bd - Browse repository at this point
Copy the full SHA b4be7bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33d1124 - Browse repository at this point
Copy the full SHA 33d1124View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5580354 - Browse repository at this point
Copy the full SHA 5580354View commit details
Commits on Jul 8, 2024
-
Resolving merge conflict with upstream
Attempting to resolve merge conflict that arose in storescp due to new commits in the upstream mirror. It looks like it is addressing the path construction with a slightly different approach. A second commit will be added after I check if the directory path is getting added twice.
Configuration menu - View commit details
-
Copy full SHA for f919b81 - Browse repository at this point
Copy the full SHA f919b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2aad6c3 - Browse repository at this point
Copy the full SHA 2aad6c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 016c2b7 - Browse repository at this point
Copy the full SHA 016c2b7View commit details -
Clean up of previously suggested solution in storescp
Now that master is using snprintf(), I decided to remove my previously proposed solution in favor of the snprintf() suggestion. Also, adding bracket to if statement per comments in PR.
Configuration menu - View commit details
-
Copy full SHA for 7fa7df1 - Browse repository at this point
Copy the full SHA 7fa7df1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1304f8a - Browse repository at this point
Copy the full SHA 1304f8aView commit details