Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenSSL and ZLIB targets to link against #67

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lorteddie
Copy link

Both libraries are binary compatible between versions so there is no need to depend on specific build paths of them. If available their targets should be preferred.

@VivienDelmon
Copy link

These patchs are interesting and allow to further deploy dcmtk without hard-coded path related to the build machine.
You should just use find_dependency instead of find_package for better error messages in CMake/DCMTKConfig.cmake.in see https://stackoverflow.com/questions/50263280/difference-between-find-dependency-and-find-package-in-cmake

# Depend packages
if(DCMTK_WITH_ZLIB)
if(NOT ZLIB_FOUND)
find_package(ZLIB)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, did not know about this one yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants