ENH: Replace HTML_HYPERLINK_PREFIX_FOR_CGI with std::string argument #108
Conversation
The dsr2html tool uses a hardcoded literal string as a hyperlink prefix for refrenced composite objects (images, waveforms, etc.) in rendering the Key Object Selection documents. Replace this literal with a string argument that will be passed by a calling application / function.
The dsr2html tool uses a hardcoded literal string as a hyperlink prefix for refrenced composite objects (images, waveforms, etc.) in rendering the Key Object Selection documents. Replace this literal with a string argument that will be passed by a calling application / function. Pushed upstream: DCMTK/dcmtk#108
| const size_t flags) const | ||
| { | ||
| /* render reference */ | ||
| docStream << "<a href=\"" << HTML_HYPERLINK_PREFIX_FOR_CGI; | ||
| docStream << "<a href=\"" << urlPrefixToCompositeObjects; |
There was a problem hiding this comment.
Do we need to change these lines to this?
docStream << "<a href=\"" << urlPrefixToCompositeObjects.c_str();Or the current one is fine?
|
Thank you for your contribution. I've already checked your proposed patch and applied it locally with a few modifications (e.g. regarding DCMTK conventions, missing API documentation, order of parameters). I will probably also add a new command line option to dsr2html that allows for specifying the URL prefix for hyperlinks to composite objects. |
|
A brief interim report: It seems that I now managed to get rid of the warnings that were shown when compiled with gcc and option -Woverloaded-virtual. After some more testing, I will merge the changes to "testing" and then later to the "master" branch. |
Made URL prefix for hyperlinks to composite objects configurable. The default behavior is to use the URL prefix http://localhost/dicom.cgi, which is e.g. needed for DICOMscope. Thanks to GitHub user "thewtex" (Matt McCormick) for the proposal and the original patch. See GitHub pull request #108 for details.
|
I just pushed the changes I have made to the public DCMTK git repository. See commit bd3dd3e. |
The dsr2html tool uses a hardcoded literal string as a hyperlink prefix for refrenced composite objects (images, waveforms, etc.) in rendering the Key Object Selection documents.
Replace this literal with a string argument that will be passed by a calling application / function.
@michaelonken here is a patch that would be helpful to upstream.
CC @jadh4v @fedorov