Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable days names #169

Closed
vegon opened this issue Nov 21, 2024 · 2 comments · Fixed by #204
Closed

Customizable days names #169

vegon opened this issue Nov 21, 2024 · 2 comments · Fixed by #204
Assignees
Labels
enhancement New feature or request research & development Exploratory R&D to help figure things out
Milestone

Comments

@vegon
Copy link

vegon commented Nov 21, 2024

Title. It would help with immersion.

And also, if possible, change the numbers of days per week (useful for people using the Faerun calendar).

@DC23 DC23 self-assigned this Nov 21, 2024
@DC23 DC23 added enhancement New feature or request research & development Exploratory R&D to help figure things out labels Nov 21, 2024
@DC23
Copy link
Owner

DC23 commented Nov 21, 2024

I was trying to avoid integration with something like Simple Calendar, in order to keep this module simple. Ironic isn't it?

I can definitely implement 7 named days of the week. Different numbers of days in a week is easy if those days don't have names, but trickier if both the names and numbers need to vary due to the way module settings work. I'd need to look at Simple Calendar integration, which I don't want to do. The SmallTime module already does that and I'd rather focus on small and simple with Dragonbane support, which SmallTime doesn't do.

There is another approach, which involves loading the days from a JSON definitions file. That's not easy to use so is the option of last resort.

There could also be other approaches in Foundry that I don't know about yet, so I'll look into that.

Long answer to explain why this is a feature that's going to arrive in small pieces, and some of those later pieces are trickier than they might appear.

@DC23
Copy link
Owner

DC23 commented Nov 25, 2024

weekday-names
I've implemented this (will be in release v0.9.0) for 7 weekdays.

At present, the names only appear in the hover text on the graphical clock for days of the week. I'm going to make a new issue for redoing the first display line in the screenshot that reads "9:45 AM on day 26". What I really want is simple:

  • a short time display as default. It just shows the time in 12 or 24 hour time. I already have that.
  • a more standard long-form time display, showing time, day and week.

I'm going to do this right away but need to track it as a new feature because it's a discrete chunk of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request research & development Exploratory R&D to help figure things out
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants