Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregates, patch broadcasting, and refactoring #375

Merged
merged 33 commits into from
Jun 8, 2024
Merged

Conversation

d-chambers
Copy link
Contributor

@d-chambers d-chambers commented May 16, 2024

Description

This is a large PR which implements a few significant changes/improvements:

  1. Adds shortcuts for common patch aggregations (min, max, std, etc.)
  2. Implements patch broadcasting and sub-selection when applying operations
  • Operations can now be applied to patches of different shapes but shared, or broadcastable, dimensions
  1. Support for non-coordinate dimensions
  2. Adds the ability to use arrays in Patch.select
  3. A new method Patch.order which behaves like dataframe.loc
  4. Fixed a few small deprecations from external libraries and bugs with the time utils.

TODO

  • Add spool.concat method
  • Add concat to docs
  • Add order to docs
  • Add examples of non-coord dimensions in Patch and Coordinate section of docs
  • Add order and select docs, be sure they reference each other
  • Add example of appending and re-arranging dims in docs

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@d-chambers d-chambers added patch related to Patch class spool related to Spool class labels May 16, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (e206fc2) to head (d39605e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   99.60%   99.83%   +0.23%     
==========================================
  Files         105      106       +1     
  Lines        8050     8625     +575     
==========================================
+ Hits         8018     8611     +593     
+ Misses         32       14      -18     
Flag Coverage Δ
unittests 99.83% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers added no_ci disables CI labels May 28, 2024
@d-chambers d-chambers removed the no_ci disables CI label Jun 5, 2024
docs/tutorial/patch.qmd Outdated Show resolved Hide resolved
@d-chambers d-chambers merged commit dea01ab into master Jun 8, 2024
15 checks passed
@d-chambers d-chambers deleted the aggregates branch June 8, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch related to Patch class spool related to Spool class
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants