#1668: initialize collection stats phase

[nmm0]

Fixes #1668

[github-actions]

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (clang-9, ubuntu, mpich)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (clang-12, ubuntu, mpich)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (clang-13, ubuntu, mpich)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (clang-11, ubuntu, mpich)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (clang-14, ubuntu, mpich)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (clang-10, ubuntu, mpich)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (intel icpc, ubuntu, mpich)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

Compilation - successful

Testing - passed

Build log

---

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 2b39b4a (2023-10-18 13:26:11 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(154): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

---

[nmm0]

There appear to be some issues with this implementation that are not caught by new or existing tests, but show up in one of my application runs. So I'm investigating what the cause is.

[thearusable]

There appear to be some issues with this implementation that are not caught by new or existing tests, but show up in one of my application runs. So I'm investigating what the cause is.

@nmm0 Were you able to identify the issue?

[nmm0]

@nmm0 Were you able to identify the issue?

Hey @thearusable sorry, I haven't had a chance, I've been out sick for a little while. I'll be looking into it but the main thing is that on one of the NimbleSM application runs, it eventually fails with a mismatched phase number. I'm not sure what the exact cause of it is, but I think it may be an inserted element not getting its phase number set correctly (I did remove that logic from the insert function but thought it would be covered in the other function it got moved to).