#2040 Clarify reference to static member functions in template argument to appease nvcc 11.4 #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why it doesn't complain at line 866. Maybe because it's nested in a lambda? At line 540 I think it doesn't complain because that reference is in a dependent context, with the additional template on Should we just adjust all of these cases proactively, so we don't have to revisit this later? |
…nt to appease nvcc 11.4
…endMsg template arguments that nvcc didn't complain about this time
PhilMiller
force-pushed
the
2040-appease-cuda
branch
from
bd57f3c to
de4cd03
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2041 +/- ##
===========================================
- Coverage 84.46% 84.45% -0.01%
===========================================
Files 732 732
Lines 25843 25843
===========================================
- Hits 21828 21826 -2
- Misses 4015 4017 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2040