Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GoogleTest (GTest) to at least 1.12.0 to get newer CMake dependency #1958

Closed
PhilMiller opened this issue Sep 13, 2022 · 0 comments · Fixed by #1966
Closed

Update GoogleTest (GTest) to at least 1.12.0 to get newer CMake dependency #1958

PhilMiller opened this issue Sep 13, 2022 · 0 comments · Fixed by #1966
Labels
type: task

Comments

@PhilMiller
Copy link
Member

We've started getting warnings about Google Test's CMakeLists.txt specifying a minimum dependency on CMake 2.8, which is old enough that newer CMake doesn't want to maintain compatibility with it much longer.

Google Test 1.12.0 bumps that to CMake 3.5. Let's try upgrading to 1.12.1, the last release before their 'live at HEAD' transition.

Per #1807,

  • Update GTest to a more recent version
  • Verify that our tests work correctly with the new GTest
lifflander added a commit that referenced this issue Sep 19, 2022
@lifflander
#1958: lib: update googletest to 1.12.1
e8708be
@lifflander lifflander linked a pull request Sep 19, 2022 that will close this issue
#1958: lib: update googletest to 1.12.1 #1966
Merged
@lifflander lifflander mentioned this issue Sep 19, 2022
Merged
nlslatt pushed a commit that referenced this issue Oct 20, 2022
@lifflander @nlslatt
#1958: lib: update googletest to 1.12.1
4528cd4
nlslatt added a commit that referenced this issue Oct 20, 2022
@nlslatt
#1958: lib: update googletest to main
3c4feeb
nlslatt added a commit that referenced this issue Oct 20, 2022
@nlslatt
#1958: lib: avoid intel warning about unknown gcc opt
c894bf5
nlslatt added a commit that referenced this issue Oct 21, 2022
@nlslatt
Merge pull request #1966 from DARMA-tasking/1958-update-googletest-gt…
72e3a0a 
…est-to-at-least-1120-to-get-newer-cmake-dependency

#1958: lib: update googletest to 1.12.1
cz4rs pushed a commit that referenced this issue Nov 8, 2022
@lifflander @cz4rs
#1958: lib: update googletest to 1.12.1
3f20c6c
cz4rs pushed a commit that referenced this issue Nov 8, 2022
@nlslatt @cz4rs
#1958: lib: avoid intel warning about unknown gcc opt
d979799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1958: lib: update googletest to 1.12.1 DARMA-tasking/vt
1 participant
@PhilMiller