Skip to content

Commit

Permalink
#2212: callback: stop using CBTrait for params which misses the MsgProps
Browse files Browse the repository at this point in the history
  • Loading branch information
lifflander committed Nov 29, 2023
1 parent dc81d4e commit 05bb801
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/vt/pipe/callback/cb_union/cb_raw_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,7 @@ struct CallbackTyped : CallbackRawBaseSingle {

template <typename... Params>
void sendTuple(std::tuple<Params...> tup) {
using Trait = CBTraits<Args...>;
using MsgT = messaging::ParamMsg<typename Trait::TupleType>;
using MsgT = messaging::ParamMsg<std::tuple<std::decay_t<Params>...>>;
auto msg = vt::makeMessage<MsgT>();
msg->setParams(std::move(tup));
CallbackRawBaseSingle::sendMsg<MsgT>(msg);
Expand All @@ -243,7 +242,7 @@ struct CallbackTyped : CallbackRawBaseSingle {
void send(Params&&... params) {
using Trait = CBTraits<Args...>;
if constexpr (std::is_same_v<typename Trait::MsgT, NoMsg>) {
using MsgT = messaging::ParamMsg<typename Trait::TupleType>;
using MsgT = messaging::ParamMsg<std::tuple<std::decay_t<Params>...>>;
auto msg = vt::makeMessage<MsgT>();
msg->setParams(std::forward<Params>(params)...);
CallbackRawBaseSingle::sendMsg<MsgT>(msg);
Expand Down

0 comments on commit 05bb801

Please sign in to comment.